File search

Hi was just wondering if anyone could help me with this.

I've got a file that logs ip addresses and I want to search the file for
occurences of the current users ip address so that only one vote can be
cast, I've tryed the following script but for some reason the in_array
function always returns false whether the ip address occurs in the file or
not. Maybe im just doing it wrong.

Thanks

Will.

|----heres the current script ----|

$ipfile = "votedip.txt";
$filesize = filesize($ipfile);
$handle = fopen($ipfile, "a+");

//fwrite($handle, $userip);
fclose($handle);

$ipsvoted = file($ipfile);

if (in_array("192.62.1.2",$ipsvoted))
{
echo "voted already";
}
else
{
echo "thanks for your vote";
}

hi

> I've got a file that logs ip addresses and I want to search the file for
> occurences of the current users ip address so that only one vote can be
> cast, I've tryed the following script but for some reason the in_array
> function always returns false whether the ip address occurs in the file
> or not. Maybe im just doing it wrong.

have a look to votedip.txt: are saved adresses seperated by newlines?
in_array returns false if you read saved adresses using file, because file
doesn't remove newline-chars.

> $ipfile = "votedip.txt";
> $filesize = filesize($ipfile);

do you need the filesize? the actual sizes of ip-adresses differ. think of
sizeof($ipsvoted), if you want a fixed number of adresses to be saved.

> $handle = fopen($ipfile, "a+");

$handle = fopen($ipfile, "a");

> //fwrite($handle, $userip);

fwrite($handle, "$userip\n");

> fclose($handle);
> $ipsvoted = file($ipfile);

$ipsvoted = array_map("rtrim", file($ipfile));

> if (in_array("192.62.1.2",$ipsvoted))
> {
> echo "voted already";
> }
> else
> {
> echo "thanks for your vote";
> }

maybe this helps you (not tested):

function vote($ip_addr) {
$ipfile = "votedip.txt";
$ipsvoted = array_map("rtrim", file($ipfile);
if (in_array($ip_addr, $ipsvoted)) {
echo "voted already";
} else {
$handle = fopen($ipfile, "a");
fwrite($handle, $userip);
fclose($handle);
echo "thanks for your vote";
}
}

you may want to remove old adresses, because $ipfile could become very
large.

regards, steffen

--
Using M2, Opera's revolutionary e-mail client: http://www.opera.com/m2/

> have a look to votedip.txt: are saved adresses seperated by newlines?
> in_array returns false if you read saved adresses using file, because
> file doesn't remove newline-chars.

i meant: in_array() returns false if you use file() to get the lines of
"votedip.txt" because file() doesn't remove any linebreaks (\n|\r\n|\r).
"example" != "example\n". that's why you should rtrim() the whole array
first:

$ipsvoted = array_map("rtrim", file($ipfile));

(i forgot one paranthesis and one linebreak in the function i submitted
before). this is the (more) correct version:

function vote($ip_addr) {
$ipfile = "votedip.txt";
$ipsvoted = array_map("rtrim", file($ipfile));
if (in_array($ip_addr, $ipsvoted)) {
echo "voted already";
} else {
$handle = fopen($ipfile, "a");
fwrite($handle, "$userip\n");
fclose($handle);
echo "thanks for your vote";
}
}

steffen

--
Using M2, Opera's revolutionary e-mail client: http://www.opera.com/m2/